fix(sql): support sqlc.arg in ORDER BY expressions#4429
Open
mujib77 wants to merge 1 commit intosqlc-dev:mainfrom
Open
fix(sql): support sqlc.arg in ORDER BY expressions#4429mujib77 wants to merge 1 commit intosqlc-dev:mainfrom
mujib77 wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes handling of
sqlc.arg()insideORDER BYexpressions during named parameter rewriting.While testing queries using named parameters in conditional ordering logic, I noticed that parameters used inside
ORDER BYexpressions were not being rewritten correctly. The rewrite flow was missing these cases during parameter processing.This change updates the rewrite handling and adds regression test coverage for the behavior.
Example
Query:
Before this change, the named parameter inside the
ORDER BYexpression was not rewritten correctly.After this change,
sqlc.arg(name)is properly detected and rewritten during parameter processing.Changes
ORDER BYexpressionsparameters_test.gogo test ./internal/sql/rewrite